Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support feeling client disconnetion #1054

Merged

Conversation

Ricky-chen1
Copy link
Contributor

@Ricky-chen1 Ricky-chen1 commented Jan 27, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 支持感知客户端的断连状态

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
1. It only applies to netpoll.
2. After opening, the context in the request will be cancelled.
zh(optional):
1. 仅适用于netpoll
2. 开启后请求中的context将会被取消

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@Ricky-chen1 Ricky-chen1 requested review from a team as code owners January 27, 2024 16:12
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (b7cbc9d) to head (277d4a3).
Report is 20 commits behind head on develop.

Current head 277d4a3 differs from pull request most recent head 33975b6

Please upload reports for the commit 33975b6 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
===========================================
+ Coverage    82.79%   82.81%   +0.02%     
===========================================
  Files           98       98              
  Lines        10032    10062      +30     
===========================================
+ Hits          8306     8333      +27     
- Misses        1236     1238       +2     
- Partials       490      491       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Haswf
Copy link
Contributor

Haswf commented Jan 29, 2024

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/app/server/hertz_test.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch 7 times, most recently from 8bdaf3f to d8b84b2 Compare February 12, 2024 11:53
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch from d8b84b2 to b064297 Compare February 12, 2024 11:54
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch 4 times, most recently from dfa79d0 to 2d21bec Compare February 19, 2024 03:41
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch from 2d21bec to 7d8a8c0 Compare February 23, 2024 15:50
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch from 7d8a8c0 to bea3fbd Compare May 9, 2024 04:21
@li-jin-gou li-jin-gou force-pushed the feat/add_sense_client_disconnection branch from 3807fab to 33975b6 Compare May 28, 2024 08:52
@li-jin-gou li-jin-gou merged commit 0fe1182 into cloudwego:develop May 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants