optimize(hz): use relative path for grpc generated file #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please sign the CLA |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1022 +/- ##
===========================================
+ Coverage 82.55% 82.60% +0.05%
===========================================
Files 98 98
Lines 9974 9974
===========================================
+ Hits 8234 8239 +5
+ Misses 1244 1240 -4
+ Partials 496 495 -1 ☔ View full report in Codecov by Sentry. |
loveyana
force-pushed
the
fix/use-relative-path
branch
from
f62a50f
to
26dde13
Compare
FGYFFFF
approved these changes
Dec 12, 2023
welkeyever
changed the title
|
Please fill the PR description according to the template. Here is a example: #1016 |
FGYFFFF
changed the title
welkeyever
reviewed
Jan 10, 2024
| @@ -364,6 +364,10 @@ func (plugin *Plugin) GenerateFile(gen *protogen.Plugin, f *protogen.File) error | |||
| if strings.HasPrefix(impt, plugin.Package) { | |||
| impt = impt[len(plugin.Package):] | |||
| } | |||
| // The file name must be the relative path, reference https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/compiler/plugin.proto#L122 | |||
| if strings.HasPrefix(impt, "/") { | |||
| impt = impt[1:] | |||
There was a problem hiding this comment.
Removing the prefix “/” directly is not always right way to transfer absolute path to relative path?
An implicit premise is that the current work dir needs to be in "/"?
If there is something I missed please let me know🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
go_package 使用相对路径去适配 grpc 的生成代码
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: go_package use relative path to adapt 'grpc-generated code'
zh(optional): go_package 使用相对路径去适配 grpc 的生成代码
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: