Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor: json config #1013

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Dec 1, 2023

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

重构 Hertz JSON 相关的配置

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: refactor json config
zh(optional):

  • json 私有化,禁止修改
  • binding json 配置修改
  • render json 配置修改

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners December 1, 2023 08:14
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a327795) 82.48% compared to head (7cbbfba) 82.55%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1013      +/-   ##
===========================================
+ Coverage    82.48%   82.55%   +0.06%     
===========================================
  Files           98       98              
  Lines         9964     9978      +14     
===========================================
+ Hits          8219     8237      +18     
+ Misses        1249     1245       -4     
  Partials       496      496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF changed the title WIP: refactor: json config Draft: refactor: json config Dec 1, 2023
@FGYFFFF FGYFFFF changed the title Draft: refactor: json config WIP: refactor: json config Dec 1, 2023
@FGYFFFF FGYFFFF marked this pull request as draft December 1, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant