Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to include this ctx.Response.Header.SetContentEncodingBytes <- ? #449

Closed
kolinfluence opened this issue Dec 3, 2022 · 8 comments · Fixed by #456
Closed

possible to include this ctx.Response.Header.SetContentEncodingBytes <- ? #449

kolinfluence opened this issue Dec 3, 2022 · 8 comments · Fixed by #456
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@kolinfluence
Copy link

kolinfluence commented Dec 3, 2022

just this will do.

ctx.Response.Header.SetContentEncodingBytes 

the rest can work around. thx

@kolinfluence kolinfluence changed the title how do i work around setting Response header kv under protocol? possible to include this ctx.Response.Header.SetContentEncodingBytes <- ? Dec 3, 2022
@kolinfluence
Copy link
Author

after 2 weeks of workarounds, i'm finally left with this last part. seemed a lot of "missing" compatibility features but can be fixed no issue. great work guys. i think mostly a lot of copying and pasting needed.

pls help with this last section as the rest i've already figured out how to workaround checking the codes. only this last section is not evident. thx!

@kolinfluence
Copy link
Author

@li-jin-gou can i buy u a coffee when this and #428 is resolved as token of appreciation?

thx a lot for the help extended so far here, on fasthttp and fiber.

@li-jin-gou li-jin-gou added the question Further information is requested label Dec 4, 2022
@li-jin-gou
Copy link
Member

just this will do.

ctx.Response.Header.SetContentEncodingBytes 

the rest can work around. thx

Hertz does not currently support this feature, you can use ctx.Response.Header.Set.

@li-jin-gou
Copy link
Member

@li-jin-gou can i buy u a coffee when this and #428 is resolved as token of appreciation?

thx a lot for the help extended so far here, on fasthttp and fiber.

This is not necessary, as far as I know, you are the first person to use the Hertz HTTP2 feature in open-souece and we appreciate your trust in Hertz.

@li-jin-gou
Copy link
Member

Same as valyala/fasthttp#1311 and I think we can also support it.

@li-jin-gou li-jin-gou added the good first issue Good for newcomers label Dec 4, 2022
@wang-tsh
Copy link
Contributor

wang-tsh commented Dec 5, 2022

Please assign me.

@li-jin-gou
Copy link
Member

Please assign me.

thanks

@wang-tsh
Copy link
Contributor

wang-tsh commented Dec 5, 2022

Please assign me.

thanks

my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Development

Successfully merging a pull request may close this issue.

3 participants