Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip click-8.0.2 but allow patched versions #60

Merged
merged 1 commit into from Oct 11, 2021

Conversation

sanderr
Copy link
Contributor

@sanderr sanderr commented Oct 11, 2021

A couple of days ago the click dependency was constrained to <8.0.2 because of a bug in that version (#57). The bug has since been fixed and released as click-8.0.3 (pallets/click#2088, pallets/click#2094, https://click.palletsprojects.com/en/8.0.x/changes/#version-8-0-3). I believe the constraint could now be loosened to only disallow 8.0.2.

@dylwylie
Copy link
Contributor

closing & re-opening to retrigger circleci

@dylwylie dylwylie closed this Oct 11, 2021
@dylwylie dylwylie reopened this Oct 11, 2021
@dylwylie
Copy link
Contributor

Hey @sanderr - thanks for the contribution. I'm afraid I'm blocked from merging this because the repository settings requires commits to be signed.

If you'd like to do so there's some info here https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

If not - no worries I can remake the same change later!

@sanderr
Copy link
Contributor Author

sanderr commented Oct 11, 2021

Thanks for the pointer. I've set it up but I'm not sure how to continue now. Do I understand correctly that all commits in this pull request need to be signed and that I can't go back and sign commits I've already pushed? Should I sign the commit locally and force push it then?

@dylwylie
Copy link
Contributor

Yeah you can sign existing commits but that changes the commit hash so a force push will be required!

@codeclimate
Copy link

codeclimate bot commented Oct 11, 2021

Code Climate has analyzed commit 4002883 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 1.0% (0.0% change).

View more on Code Climate.

@dylwylie dylwylie merged commit 5af1989 into cloudsmith-io:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants