fix: Properly handle records with multiple rows in batching #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
yevgenypats,
hermanschaaf and
erezrokah
as code owners
1 task
disq
reviewed
Apr 22, 2024
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
disq
reviewed
Apr 23, 2024
|
TODO: Consider making a slicer to handle batching by rows & size. This is complicated by the fact that different batchers use different messages, so an overhaul might be required for this. |
erezrokah
reviewed
May 14, 2024
There was a problem hiding this comment.
Added a few comments, the main ones are:
- Don't think we need the abstraction over int64 as it's basically wrapping
+=,>andGet - This seems to change the logic to flush after the limit had reached instead of before, it won't be an issue for limiting by rows I think (since it works the same for single row records, and is broken for multi row records anyway), but can be an issue for limiting by bytes. Regardless probably best to flush before going over the limit
Also per your comment in #1647 (comment) if we roll out multi-rows this will become an issue for batching both by rows and by bytes, and with single rows records we're less likely to exceed the batch size.
Not sure what to do about that, and how slicing can impact the performance improvements we get from multi records
candiduslynx
commented
May 14, 2024
candiduslynx
force-pushed
the
fix/batch-by-rows
branch
from
6ba3a90
to
1f44030
Compare
erezrokah
approved these changes
May 15, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 15, 2024
🤖 I have created a release *beep* *boop* --- ## [4.42.1](v4.42.0...v4.42.1) (2024-05-15) ### Bug Fixes * Correct error message on Read failure ([#1680](#1680)) ([dc31c3a](dc31c3a)) * Properly handle records with multiple rows in batching ([#1647](#1647)) ([926a7fc](926a7fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1567
Out of scope: https://github.com/cloudquery/cloudquery-issues/issues/1655