feat!: Remove docs generation from SDK #1142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
- Coverage 48.71% 48.39% -0.32%
==========================================
Files 85 83 -2
Lines 7833 7680 -153
==========================================
- Hits 3816 3717 -99
+ Misses 3682 3642 -40
+ Partials 335 321 -14
☔ View full report in Codecov by Sentry. |
erezrokah
approved these changes
Aug 10, 2023
|
I still think we should do this, but before merging we need to also make sure the scaffold Makefile is updated to not reference this command anymore. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes docs generation from the SDK. This functionality moved to the CloudQuery CLI in cloudquery/cloudquery#12758.
Users should now use the
cloudquery tablescommand to achieve similar functionality as before.Note: I decided to remove the JSON generation in this PR as well. We may bring this back in the future, but it might be in a different shape then so I think we can leave that decision for later.