This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Refactor/no diags #437
Draft
Refactor/no diags #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2022
roneli
reviewed
Jul 24, 2022
There was a problem hiding this comment.
Had one comment, regarding the proto, make sure running a new provider version will work with a diag based core, i.e works but doesn't print diags. Unless we don't want that so in that case increase the proto version so there will be a mismatch and users will have to upgrade.
Comment on lines
-190
to
-191
| clock := stats.NewClockWithObserve("callTableResolve", segmentStats.Tag{Name: "client_id", Value: identifyClient(client)}, segmentStats.Tag{Name: "table", Value: e.Table.Name}) | ||
| defer clock.Stop() |
There was a problem hiding this comment.
why did u remove the stats? this is so we can see when we have hanging resolvers that are still running
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much wip but this is removing use of diags which due to the nature of it "infects" the whole code-bases similar to
context. We are moving to pure logging as it is already structured and it is being send anyway to the core by the hashicorp go-plugin library.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)