Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(aws): Remove some unused constants #9370

Merged
merged 2 commits into from Mar 23, 2023
Merged

chore(aws): Remove some unused constants #9370

merged 2 commits into from Mar 23, 2023

Conversation

hermanschaaf
Copy link
Member

awsFailedToConfigureErrMsg and awsOrgsFailedToFindMembers may have been used at some point, but right now they are not

@cq-bot cq-bot added the aws label Mar 22, 2023
@erezrokah
Copy link
Contributor

Hmm, I'd expect our linter to report this...

@erezrokah
Copy link
Contributor

erezrokah commented Mar 22, 2023 •
edited

They finally support generics for all linters so maybe worth updating golangci/golangci-lint#2649 (comment) as they had a few disabled

@hermanschaaf hermanschaaf added the automerge Automatically merge once required checks pass label Mar 23, 2023
@kodiakhq kodiakhq bot merged commit 1eae425 into main Mar 23, 2023
11 checks passed
@kodiakhq kodiakhq bot deleted the aws-dead-code branch March 23, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
Framework
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hermanschaaf @erezrokah @yevgenypats @cq-bot