Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a workflow for greetings when users first interactive with repo #3175

Merged
merged 3 commits into from
Oct 23, 2022
Merged

feat: Add a workflow for greetings when users first interactive with repo #3175

merged 3 commits into from
Oct 23, 2022

Conversation

cychiang
Copy link
Contributor

@cychiang cychiang commented Oct 22, 2022 •
edited

Summary

This PR is based on the issue #3161

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Test locally on your own infrastructure
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@cychiang cychiang mentioned this pull request Oct 22, 2022
Closed
erezrokah
erezrokah requested changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cychiang lets start only with an issue comment.

Please let me know what you think

.github/workflows/greetings.yml Outdated Show resolved Hide resolved
@cychiang cychiang marked this pull request as ready for review October 23, 2022 11:50
erezrokah
erezrokah approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'll wait for others to approve too, cc @cloudquery/cloudquery-opensource

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Oct 23, 2022
@kodiakhq kodiakhq bot merged commit bd1d185 into cloudquery:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@erezrokah erezrokah erezrokah approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cychiang @yevgenypats @erezrokah