feat: Introduce spec JSON schema #14296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
candiduslynx
force-pushed
the
feat/jsonschema/aws
branch
from
d882ca3
to
9d0d17a
Compare
candiduslynx
force-pushed
the
feat/jsonschema/aws
branch
from
40389af
to
856f23a
Compare
candiduslynx
requested review from
yevgenypats,
disq and
hermanschaaf
as code owners
disq
reviewed
Oct 5, 2023
Merged
disq
reviewed
Oct 5, 2023
bbernays
reviewed
Oct 5, 2023
disq
approved these changes
Oct 5, 2023
candiduslynx
force-pushed
the
feat/jsonschema/aws
branch
from
ff0acad
to
c4834ef
Compare
disq
approved these changes
Oct 6, 2023
|
This looks good. Does this PR leave us with a clear path on how to remove all of our own custom |
We can just drop |
bbernays
approved these changes
Oct 6, 2023
erezrokah
added a commit
that referenced
this pull request
Oct 13, 2023
🤖 I have created a release *beep* *boop* --- ## [22.15.0](plugins-source-aws-v22.14.0...plugins-source-aws-v22.15.0) (2023-10-13) ### Features * Deleted query origin_access_identity_enabled.sql ([#13921](#13921)) ([ec77ff8](ec77ff8)) * Introduce spec JSON schema ([#14296](#14296)) ([c35f473](c35f473)) * **services:** Support newly added regions ([#14481](#14481)) ([672772c](672772c)) * Updated query api_gw_cache_encrypted.sql ([#13860](#13860)) ([dca3fe0](dca3fe0)) * Updated query of security_groups_with_access_to_unauthorized_ports ([#13855](#13855)) ([efa9e34](efa9e34)) * Updated query of security_groups_with_open_critical_ports ([#13854](#13854)) ([6834ee9](6834ee9)) * Updated query rds_databases_and_clusters_should_not_use_a_datab… ([#13936](#13936)) ([810078f](810078f)) * Updated query secrets_configured_with_automatic_rotation_should… ([#13934](#13934)) ([8b1293c](8b1293c)) * Updated query unused_acls.sql ([#13859](#13859)) ([f47df0c](f47df0c)) ### Bug Fixes * Added check for empty string health_status ([#13861](#13861)) ([37d8875](37d8875)) * Changed ssm.2 query to reduce redundent rows ([#13933](#13933)) ([cee1fab](cee1fab)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([#14459](#14459)) ([7ce40f8](7ce40f8)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([#14475](#14475)) ([83fe7ca](83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([#14503](#14503)) ([4056593](4056593)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([#14378](#14378)) ([a2e0c46](a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([#14436](#14436)) ([d529e2d](d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([#14489](#14489)) ([9bb45dc](9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([#14516](#14516)) ([2d905bf](2d905bf)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([#14500](#14500)) ([9e603d5](9e603d5)) * Fallback to `eu-west-1` if a given buckets LocationConstraint is `EU` ([#14476](#14476)) ([f6433e7](f6433e7)) * Lowercase policy statement in query for KMS.1 ([#13858](#13858)) ([b161fe1](b161fe1)) * Proper schema for `CustomECSListTasksInput.MaxResults` ([#14502](#14502)) ([cdaaa99](cdaaa99)) * Redact Code Location and Fall back to other APIs to fully resolve `aws_lambda_functions` ([#14381](#14381)) ([bf402f4](bf402f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Extracted from cloudquery#14296
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Closes cloudquery#14027 Blocked by: * cloudquery/codegen#39 * invopop/jsonschema#109 – merged to `cloudquery/jsonschema@cqmain` * invopop/jsonschema#110 – merged to `cloudquery/jsonschema@cqmain` I propose reviewing the annotations along with tests, as the JSON schemas generated are just too long to grasp visually.
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
…folder_ids` (cloudquery#14448) Tests & schema fixes are inspired by cloudquery#14296
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
🤖 I have created a release *beep* *boop* --- ## [22.15.0](cloudquery/cloudquery@plugins-source-aws-v22.14.0...plugins-source-aws-v22.15.0) (2023-10-13) ### Features * Deleted query origin_access_identity_enabled.sql ([cloudquery#13921](cloudquery#13921)) ([ec77ff8](cloudquery@ec77ff8)) * Introduce spec JSON schema ([cloudquery#14296](cloudquery#14296)) ([c35f473](cloudquery@c35f473)) * **services:** Support newly added regions ([cloudquery#14481](cloudquery#14481)) ([672772c](cloudquery@672772c)) * Updated query api_gw_cache_encrypted.sql ([cloudquery#13860](cloudquery#13860)) ([dca3fe0](cloudquery@dca3fe0)) * Updated query of security_groups_with_access_to_unauthorized_ports ([cloudquery#13855](cloudquery#13855)) ([efa9e34](cloudquery@efa9e34)) * Updated query of security_groups_with_open_critical_ports ([cloudquery#13854](cloudquery#13854)) ([6834ee9](cloudquery@6834ee9)) * Updated query rds_databases_and_clusters_should_not_use_a_datab… ([cloudquery#13936](cloudquery#13936)) ([810078f](cloudquery@810078f)) * Updated query secrets_configured_with_automatic_rotation_should… ([cloudquery#13934](cloudquery#13934)) ([8b1293c](cloudquery@8b1293c)) * Updated query unused_acls.sql ([cloudquery#13859](cloudquery#13859)) ([f47df0c](cloudquery@f47df0c)) ### Bug Fixes * Added check for empty string health_status ([cloudquery#13861](cloudquery#13861)) ([37d8875](cloudquery@37d8875)) * Changed ssm.2 query to reduce redundent rows ([cloudquery#13933](cloudquery#13933)) ([cee1fab](cloudquery@cee1fab)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to d401686 ([cloudquery#14459](cloudquery#14459)) ([7ce40f8](cloudquery@7ce40f8)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.6 ([cloudquery#14475](cloudquery#14475)) ([83fe7ca](cloudquery@83fe7ca)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.8 ([cloudquery#14503](cloudquery#14503)) ([4056593](cloudquery@4056593)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.2 ([cloudquery#14378](cloudquery#14378)) ([a2e0c46](cloudquery@a2e0c46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.3 ([cloudquery#14436](cloudquery#14436)) ([d529e2d](cloudquery@d529e2d)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.4 ([cloudquery#14489](cloudquery#14489)) ([9bb45dc](cloudquery@9bb45dc)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.12.5 ([cloudquery#14516](cloudquery#14516)) ([2d905bf](cloudquery@2d905bf)) * **deps:** Update module golang.org/x/net to v0.17.0 [SECURITY] ([cloudquery#14500](cloudquery#14500)) ([9e603d5](cloudquery@9e603d5)) * Fallback to `eu-west-1` if a given buckets LocationConstraint is `EU` ([cloudquery#14476](cloudquery#14476)) ([f6433e7](cloudquery@f6433e7)) * Lowercase policy statement in query for KMS.1 ([cloudquery#13858](cloudquery#13858)) ([b161fe1](cloudquery@b161fe1)) * Proper schema for `CustomECSListTasksInput.MaxResults` ([cloudquery#14502](cloudquery#14502)) ([cdaaa99](cloudquery@cdaaa99)) * Redact Code Location and Fall back to other APIs to fully resolve `aws_lambda_functions` ([cloudquery#14381](cloudquery#14381)) ([bf402f4](cloudquery@bf402f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14027
Blocked by:
cloudquery/jsonschema@cqmainNullableFromTypeoption invopop/jsonschema#110 – merged tocloudquery/jsonschema@cqmainI propose reviewing the annotations along with tests, as the JSON schemas generated are just too long to grasp visually.