Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the test.yaml so that vendor pull works on quick start #392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding the test.yaml so that vendor pull works on quick start #392

wants to merge 3 commits into from

Conversation

thedarkwriter
Copy link

@thedarkwriter thedarkwriter commented Jun 21, 2023 •
edited

what

  • I added a short command to add a temp.yaml file so that the quick-start guide will work. Otherwise when you are creating components and run atmos vendor pull --component infra/vpc-flow-logs-bucket the command will fail.

why

  • Getting started docs should work (even with a workaround)
  • Once the command is run, you can keep going in the quick-start.

references

  • All ref was in Sweetops slack Atmos channel

@thedarkwriter thedarkwriter requested review from a team as code owners June 21, 2023 14:57
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Jun 22, 2023
@Gowiem
Copy link
Member

Gowiem commented Feb 23, 2024

@aknysh @osterman does this still being open mean that the quick-start is broken? Or was this fixed elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

@aknysh aknysh

Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thedarkwriter @Gowiem @Nuru @aknysh