Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pypy 3.8 #454

Closed
wants to merge 1 commit into from
Closed

support pypy 3.8 #454

wants to merge 1 commit into from

Conversation

dand-oss
Copy link

@dand-oss dand-oss commented Oct 21, 2021

pypy 3.8 is released for download.

pypy does not supply _pickle c extension

#455

pypy 3.8 should continue to import the pure python version of pickle.
pypy 3.7 worked because of the test to import pure python pickle if python version less than 3.7.

Check for pypy platform explicitly as fix.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dand-oss -- this seems like a sensible change. There's a centralized PYPY variable already defined here

PYPY = platform.python_implementation() == "PyPy"

Would you mind using that here instead?

EDIT: In fact, it probably more sense to move the definition of the PYPY variable into the compat.py compatibility module and then import it the variable elsewhere when needed

@ogrisel
Copy link
Contributor

ogrisel commented Jan 14, 2022

Closing in favor of #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants