New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Dask's test_pickle_empty
on CI again
#442
Run Dask's test_pickle_empty
on CI again
#442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 4 4
Lines 720 720
Branches 150 150
=======================================
Hits 665 665
Misses 34 34
Partials 21 21 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I've activated running distributed's test suite for this PR. Can you push an empty commit to trigger a new build?
Yep thanks Pierre 😄 Pushed an empty commit above |
There was one more flaky test. Added that to skip list with a reference. Otherwise seems to be working 🙂 |
thank you very much @jakirkham for your support on the |
Ofc thanks for your help as well, Pierre :) |
We needed to skip this in PR ( #432 ) as it was failing. This has since been fixed upstream ( dask/distributed#5303 ). So readd testing of it.