Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Dask's test_pickle_empty on CI again #442

Merged
merged 3 commits into from Sep 10, 2021

Conversation

jakirkham
Copy link
Member

We needed to skip this in PR ( #432 ) as it was failing. This has since been fixed upstream ( dask/distributed#5303 ). So readd testing of it.

@jakirkham jakirkham mentioned this pull request Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #442 (cc6c1a5) into master (ef6fb90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files           4        4           
  Lines         720      720           
  Branches      150      150           
=======================================
  Hits          665      665           
  Misses         34       34           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6fb90...cc6c1a5. Read the comment docs.

@pierreglaser pierreglaser added the ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle) label Sep 10, 2021
Copy link
Member

@pierreglaser pierreglaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've activated running distributed's test suite for this PR. Can you push an empty commit to trigger a new build?

@jakirkham
Copy link
Member Author

Yep thanks Pierre 😄 Pushed an empty commit above

@jakirkham
Copy link
Member Author

There was one more flaky test. Added that to skip list with a reference. Otherwise seems to be working 🙂

@pierreglaser pierreglaser merged commit 9fdb09f into cloudpipe:master Sep 10, 2021
@pierreglaser
Copy link
Member

thank you very much @jakirkham for your support on the distributed-side of cloudpickle'CI!

@jakirkham jakirkham deleted the tst_empty_pickle_dask branch September 10, 2021 17:17
@jakirkham
Copy link
Member Author

Ofc thanks for your help as well, Pierre :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants