Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic approach to dict views types #435

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

brl0
Copy link
Contributor

@brl0 brl0 commented Aug 8, 2021

This is a revisit of my previous effort to add support for dict views type objects. I had some ideas rattling around to try to make it a bit more dynamic and extensible.

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #435 (513a938) into master (343da11) will decrease coverage by 2.80%.
The diff coverage is 61.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   92.36%   89.55%   -2.81%     
==========================================
  Files           4        4              
  Lines         720      747      +27     
  Branches      150      158       +8     
==========================================
+ Hits          665      669       +4     
- Misses         34       49      +15     
- Partials       21       29       +8     
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 86.07% <56.52%> (-2.24%) ⬇️
cloudpickle/cloudpickle_fast.py 93.17% <64.86%> (-3.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343da11...513a938. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant