Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream CI #432

Merged
merged 42 commits into from Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
ea06d9e
Trigger downstream CI to fix it
ogrisel Aug 1, 2021
272aa62
CI trigger
pierreglaser Sep 8, 2021
42adc3c
FIX Install cloudpickle master in CI?
pierreglaser Sep 8, 2021
dd7e45b
isolate faulty tests
pierreglaser Sep 8, 2021
4acc15b
fight with quotes
pierreglaser Sep 8, 2021
4808777
fight with quotes
pierreglaser Sep 8, 2021
3c4f505
try different python version
pierreglaser Sep 8, 2021
fe1db95
install the downstream project last relase and not master
pierreglaser Sep 8, 2021
0e8c7a4
install last relase and not master
pierreglaser Sep 8, 2021
bd57733
cd in the right place
pierreglaser Sep 8, 2021
93018ce
bisect manually
pierreglaser Sep 8, 2021
f928a9d
bisect manually (bis)
pierreglaser Sep 8, 2021
31c9586
use new loky (!!!)
pierreglaser Sep 8, 2021
2cdbeae
try running full loky test suite
pierreglaser Sep 8, 2021
eeab7a9
try upgrading ray version
pierreglaser Sep 8, 2021
e850ef3
try to set up a ray's development env
pierreglaser Sep 8, 2021
4bffec1
move to python 3.8
pierreglaser Sep 8, 2021
567b5a5
dont ask for confirmation when setup ray dev
pierreglaser Sep 8, 2021
57e8bb8
more dir fixes
pierreglaser Sep 8, 2021
4e0d172
remove probably duplicate setup line
pierreglaser Sep 8, 2021
f7d6c51
try to disable some problematic unrelated tests
pierreglaser Sep 8, 2021
ae1fa9d
add missing distributed test dependency
pierreglaser Sep 8, 2021
5e27b11
isolate problematic test
pierreglaser Sep 8, 2021
3db9509
bisect faulty python version?
pierreglaser Sep 8, 2021
f8380e3
try jakirkham's PR
pierreglaser Sep 9, 2021
632a01d
test pickle related tests
pierreglaser Sep 9, 2021
4891d74
test full distributed test suite
pierreglaser Sep 9, 2021
aec1a2e
temporarily exclude faulty distributed test
pierreglaser Sep 9, 2021
9d05887
debug
pierreglaser Sep 9, 2021
2ca7223
debug
pierreglaser Sep 9, 2021
e064cd4
debug
pierreglaser Sep 9, 2021
4562310
debug
pierreglaser Sep 9, 2021
f5c07d8
debug
pierreglaser Sep 9, 2021
631690b
debug
pierreglaser Sep 9, 2021
289cf02
debug
pierreglaser Sep 9, 2021
daabf0a
debug
pierreglaser Sep 9, 2021
5b67156
debug
pierreglaser Sep 9, 2021
cefc2ae
debug
pierreglaser Sep 9, 2021
7c34a04
debug
pierreglaser Sep 9, 2021
df86f2f
ci trigger
pierreglaser Sep 9, 2021
7d6bb53
skip distributed flaky test
pierreglaser Sep 9, 2021
6a78999
various cleanups
pierreglaser Sep 9, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/scripts/test_downstream_project.sh
@@ -1,5 +1,7 @@
pushd ../$PROJECT
python -m pytest -vl
echo "${DISABLE_IPV6}"
echo "${PYTEST_ADDOPTS[@]}"
python -m pytest -vl "${PYTEST_ADDOPTS[@]}"
TEST_RETURN_CODE=$?
popd
if [[ "$TEST_RETURN_CODE" != "0" ]]; then
Expand Down
42 changes: 32 additions & 10 deletions .github/workflows/testing.yml
Expand Up @@ -141,9 +141,8 @@ jobs:
if: "contains(github.event.pull_request.labels.*.name, 'ci distributed') || contains(github.event.pull_request.labels.*.name, 'ci downstream')"
env:
PROJECT: distributed
TEST_REQUIREMENTS: pytest pytest-timeout numpy pandas mock bokeh fsspec>=0.3.3
TEST_REQUIREMENTS: cryptography pytest pytest-timeout numpy pandas mock bokeh fsspec>=0.3.3
PROJECT_URL: https://github.com/dask/distributed.git
PYTEST_ADDOPTS: "--timeout-method=thread --timeout=300 -m \"not avoid_travis\" -k \"not test_dask_scheduler and not test_workspace_concurrency and not test_defaults and not test_service_hosts and not test_logging_file_config and not test_hostport and not test_workdir_simple and not test_two_workspaces_in_same_directory and not test_recompute_released_results and not test_connection_args and not test_listen_args and not test_remote_access\""
strategy:
matrix:
python_version: [3.7]
Expand All @@ -156,9 +155,22 @@ jobs:
- name: Install project and dependencies
run: |
bash ./.github/scripts/install_downstream_project.sh
- name: Install developed version of cloudpickle
shell: bash
run: |
python -m pip install -e .
- name: Test the downstream project
shell: bash
run: |
bash ./.github/scripts/test_downstream_project.sh
# FIXME ipv6-related failures on Ubuntu github actions CI
# https://github.com/dask/distributed/issues/4514
export DISABLE_IPV6=1
# Skipping
# - test_pickle_empty until https://github.com/dask/distributed/pull/5303 gets merged,
# - test_dont_steal_unknown_function (https://github.com/dask/distributed/issues/3574)
# See https://github.com/cloudpipe/cloudpickle/pull/432
export PYTEST_ADDOPTS=("-k" "not test_pickle_empty and not test_dont_steal_unknown_functions")
source ./.github/scripts/test_downstream_project.sh

joblib-downstream-build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -194,7 +206,7 @@ jobs:
env:
PROJECT: loky
TEST_REQUIREMENTS: "pytest psutil"
PROJECT_URL: https://github.com/tomMoral/loky.git
PROJECT_URL: https://github.com/joblib/loky.git
strategy:
matrix:
python_version: [3.7]
Expand All @@ -204,9 +216,13 @@ jobs:
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python_version }}
- name: Install project and dependencies
- name: Install downstream project and dependencies
run: |
bash ./.github/scripts/install_downstream_project.sh
- name: Install developed version of cloudpickle
shell: bash
run: |
python -m pip install -e .
- name: Test the downstream project
run: |
bash ./.github/scripts/test_downstream_project.sh
Expand All @@ -218,21 +234,27 @@ jobs:
PROJECT: ray
strategy:
matrix:
python_version: [3.7]
python_version: [3.8]
steps:
- uses: actions/checkout@v1
- name: Set up Python 3.7
- name: Set up Python 3.8
uses: actions/setup-python@v1
with:
python-version: ${{ matrix.python_version }}
- name: Install project and dependencies
run: |
python -m pip install --upgrade -r dev-requirements.txt
python -m pip install setproctitle psutil ray==0.8.6
python -m pip install setproctitle psutil
# from https://docs.ray.io/en/master/development.html#building-ray
pip install -U https://s3-us-west-2.amazonaws.com/ray-wheels/latest/ray-2.0.0.dev0-cp38-cp38-manylinux2014_x86_64.whl
pushd ..
git clone https://github.com/ray-project/ray.git
pushd ray
python python/ray/setup-dev.py --yes
popd
popd
PROJECT_DIR=$(python -c "import os, ray; print(os.path.dirname(ray.__file__), flush=True)")
rm $PROJECT_DIR/cloudpickle/cloudpickle.py
git clone https://github.com/ray-project/ray.git ../ray
cp -R ../ray/python/ray/tests $PROJECT_DIR/tests
cp cloudpickle/cloudpickle.py $PROJECT_DIR/cloudpickle/cloudpickle.py
cp cloudpickle/compat.py $PROJECT_DIR/cloudpickle/compat.py
cp cloudpickle/cloudpickle_fast.py $PROJECT_DIR/cloudpickle/cloudpickle_fast.py
Expand Down