New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to register modules to be deeply serialized #417
Merged
Merged
Changes from 65 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
8a1578b
TST trigger the bug of #425 in a test
pierreglaser 1de1c4f
FIX remove the __builtins__ from a copy of the module
pierreglaser 05ebfd3
MNT document change inside CHANGES.md
pierreglaser 38364d6
Fixes #206.
3046111
Adding newline to end of file
05b0f83
Further flake8 changes
de1b375
More formatting fixes
261f127
Renaming function
9dcb540
Document changes in changelog
a2ec3a2
Unifying the naming convention
6e882e8
Updating naming conventions
cd1fde3
Adding broken module test
50d56a9
Resolving protocol
898cf05
Adding instnace check for TypeVar
65df95b
Merge branch 'master' into 206-deep-serialization
pierreglaser fd9d250
CLN fix linting errors
pierreglaser 5f84156
fixup! CLN fix linting errors
pierreglaser 14067eb
Making separate typevar chec, and using functions for the `_should_pi…
cce4708
cosmit
ogrisel 14a5cfe
Update cloudpickle/cloudpickle.py
Samreay ab57df8
Update tests/cloudpickle_test.py
Samreay cfcf843
Updating variable names
cc04c2b
Adding another unit test to check local module patching
c689adc
Updating names and comments
bad9f75
I am a savage that didnt run flake8 and I apologise
23cbfb3
Merge branch 'master' into 206-deep-serialization
ogrisel 261b5a8
Merge branch 'master' into 206-deep-serialization
ogrisel b29547e
Updating function and variable names
bd4967f
highlight possible bugs silenced by pytest
pierreglaser d83e25a
DOC Present the feature in the README
pierreglaser a7725bd
Removing submodules from arg as it is not directly used
Samreay c799711
TST rework the test structure
pierreglaser 11eb075
Merge branch 'master' into 206-deep-serialization
pierreglaser b111a56
TST test by simulating an interactive session
pierreglaser 4a3b3dd
CI debug sys.path issues in CI
pierreglaser ad85452
CI again
pierreglaser 4f99ad1
CI again
pierreglaser 59a0903
CI again
pierreglaser 0bf7c58
CI again
pierreglaser 43210dc
CI again
pierreglaser 2fdd912
CI again
pierreglaser 03c82cb
CI again
pierreglaser 730c11b
CI again
pierreglaser 1d97bff
CI again
pierreglaser aa12ac2
CI look only at macos ci builds
pierreglaser 93544c5
CI again
pierreglaser 2d3d1ed
TST: fix isolation procedure on linux
pierreglaser fd740f2
CI restore testing for all OSes
pierreglaser 1794c2e
TST take into account possisble PYTHONPATH values
pierreglaser a6637d5
API replace is_registered_... by list_registry
pierreglaser 866f096
CLN remove unused import
pierreglaser 1206827
TST add tests invoving namespace modules and subfolders
pierreglaser 4ee37d9
TST test pickling by value installed packages
pierreglaser 4faafbc
TST add module inside locally importable subfolder
pierreglaser dae05bb
TST add funcs with globals in _cloudpickle_testpkg
pierreglaser 3d4c896
TST remote co-existence of multiple versions of a func
pierreglaser 4f5942e
TST, FIX some crucial line dissapearing
pierreglaser c50aa4c
API enforce module-type input for registration api
pierreglaser 5843205
TST (try to) escape backslashes on windows
pierreglaser 5a2b25b
TST (try to) escape backslashes on windows (2)
pierreglaser 2b82f4d
CLN update README after API change
pierreglaser 058c537
TST fix typo in test
pierreglaser 850be6c
CLN remove stale file
pierreglaser 749a6b7
CLN clean up some un-necessary branches
pierreglaser c5bc41e
postpone relative imports handling to the future
pierreglaser 6ef5ec8
_is_registered_pickle_by_value should take a module
pierreglaser 8004bae
CLN cleaner registration API error messages
pierreglaser 418b848
CLN unused import
pierreglaser 79a38fe
Apply docs suggestions
pierreglaser 4f9af38
Update tests/cloudpickle_test.py
pierreglaser 5f079b0
fix linting errors
pierreglaser 0589dcb
more linting...
pierreglaser e4ca37d
TST fix a few test mistakes
pierreglaser 1e9a48d
DOC more in-depth context description in README
pierreglaser File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the motivation (interactive dev on a distributed cluster with long running worker processes) could be made more explicit by reusing the text I suggest in the docstring of
register_pickle_by_value
above in this review.