Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rails #1931

Merged
merged 2 commits into from Jun 12, 2023
Merged

update rails #1931

merged 2 commits into from Jun 12, 2023

Conversation

inductor
Copy link
Member

@inductor inductor commented Jun 5, 2023

No description provided.

@inductor inductor requested review from takaishi and jacopen June 5, 2023 04:02
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Jun 5, 2023
@jacopen
Copy link
Collaborator

jacopen commented Jun 5, 2023

CIこけるようになっちゃったね

@inductor
Copy link
Member Author

inductor commented Jun 5, 2023

DB migrateし忘れてたので再度CI走らせました

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Simplecov Report

Covered Threshold
61.54% 60%

@@ -490,8 +490,8 @@
t.string "url"
t.integer "status", default: 0, null: false
t.json "statistics", null: false
t.datetime "created_at", precision: nil, null: false
t.datetime "updated_at", precision: nil, null: false
t.datetime "created_at", null: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precision: nilがきえてるのなんだろ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec rails db:migrate の実行結果ですねー。 @jacopen

Copy link
Member Author

@inductor inductor Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rails/rails#46110 これかな〜

@jacopen jacopen self-requested a review June 6, 2023 12:40
@jacopen jacopen merged commit ab75601 into main Jun 12, 2023
4 checks passed
@jacopen jacopen deleted the update_rails branch June 12, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewapps Build ReviewApp environment automatically if this label is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants