Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forcing imports sorting using gci #440

Merged
merged 3 commits into from Aug 2, 2022
Merged

chore: forcing imports sorting using gci #440

merged 3 commits into from Aug 2, 2022

Conversation

phisco
Copy link
Contributor

@phisco phisco commented Jul 20, 2022

Closes #438

Signed-off-by: Philippe Scorsolini p.scorsolini@gmail.com

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@phisco phisco marked this pull request as draft July 28, 2022 12:18
@mnencia mnencia added go Pull requests that update Go code chore Intangible work to reduce technical debt backport-requested ◀️ This pull request should be backported to all supported releases labels Jul 29, 2022
@phisco phisco marked this pull request as ready for review August 1, 2022 13:03
@mnencia
Copy link
Member

mnencia commented Aug 2, 2022

/ok-to-merge

phisco and others added 3 commits August 2, 2022 18:33
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia mnencia merged commit d954083 into main Aug 2, 2022
@mnencia mnencia deleted the dev/438 branch August 2, 2022 18:05
mnencia added a commit that referenced this pull request Aug 2, 2022
Closes #438

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia added a commit that referenced this pull request Aug 4, 2022
Closes #438

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia added a commit that referenced this pull request Dec 29, 2022
Closes #438

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases chore Intangible work to reduce technical debt go Pull requests that update Go code ok to merge 👌 This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imports sorting should be deterministic
4 participants