Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency eslint-config-stylelint to v14 - autoclosed #191

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 14, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-stylelint 13.1.1 -> 14.0.0 age adoption passing confidence

Release Notes

stylelint/eslint-config-stylelint

v14.0.0

Compare Source

  • Added: ESM support.
  • Added: eslint-plugin-regexp plugin.
  • Removed: eslint-plugin-sort-requires plugin.

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/eslint-config-stylelint-14.x branch from 611353b to 47315c0 Compare September 20, 2021 17:19
@spaceninja
Copy link
Member

@calebeby do you understand why this is failing?

Note: this is a very low-priority request

@calebeby
Copy link
Member

@spaceninja It looks like eslint-config-stylelint wants us to use ESM instead of commonjs now.

It's not clear to me why we are using eslint-config-stylelint:

stylelint org's shareable config for ESLint
For consistent JavaScript across stylelint's repos.

@spaceninja
Copy link
Member

Ah, that's an excellent point. I can convert this to run Stylelint outside of ESLint (this is based on a very old project of mine and I copied someone else's setup).

For my own curiosity, why does the ESM change break this? Is there a require line somewhere that would need to change to an import?

@calebeby
Copy link
Member

@spaceninja There are require()'s in the tests, and the eslint rule sets the eslint environment to not have the require global, so the no-undef rule triggers.

@spaceninja
Copy link
Member

Gotcha. Thank you for the context!

@renovate renovate bot force-pushed the renovate/eslint-config-stylelint-14.x branch 3 times, most recently from 0f196b4 to e913efe Compare September 29, 2021 16:29
@renovate renovate bot force-pushed the renovate/eslint-config-stylelint-14.x branch from e913efe to 540ead3 Compare October 8, 2021 15:58
@renovate renovate bot force-pushed the renovate/eslint-config-stylelint-14.x branch from 540ead3 to e14197a Compare October 20, 2021 09:41
@renovate renovate bot changed the title Update dependency eslint-config-stylelint to v14 Update dependency eslint-config-stylelint to v14 - autoclosed Nov 2, 2021
@renovate renovate bot closed this Nov 2, 2021
@renovate renovate bot deleted the renovate/eslint-config-stylelint-14.x branch November 2, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants