Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused metron_endpoint.dropsonde_port property #534

Merged
merged 1 commit into from Feb 28, 2023

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Feb 27, 2023

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

- Remove unused BOSH property and associated config field from traffic
  controller
- Pass GRPCAddress rather than UDPAddress when creating a test server.
  gRPC-Go v1.52.0+ will error if the provided endpoint is empty:
  grpc/grpc-go#5732
Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should this be marked as a breaking change?

@acrmp
Copy link
Member Author

acrmp commented Feb 27, 2023

Should this be marked as a breaking change?

I don't think it's a breaking change as I don't believe the property has been effective since traffic controller switched to using gRPC for metrics in this story.

@acrmp acrmp merged commit 63cf49e into main Feb 28, 2023
DEPRECATED App Platform - Logging and Metrics automation moved this from Review in Progress to Done Feb 28, 2023
@acrmp acrmp deleted the pr/remove-tc-metron-dropsonde-port branch February 28, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants