Add feature flag db.enable_paginate_window #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature flag if not present it will default to the current behavior of using the window pagination, but when it is set to false it will fall back on using the other pagination method when accessing the database. Signed-off-by: João Pereira <joaod@vmware.com>
3 tasks
philippthun
reviewed
May 21, 2024
- Fix tests that are running against versions of MariaDB that do not support window function - Incorporate PR comments Signed-off-by: João Pereira <joaod@vmware.com>
philippthun
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request, please provide us with the following:
A short explanation of the proposed change:
This feature flag, if not present, will default to the current behavior of using the window pagination, but when it is set to false, it will fall back on using the other pagination method when accessing the database.
An explanation of the use cases your change solves
This change will allow the operator to disable the window for pagination for all the tables in a single place. Will also allow us to debug possible performance issues with the window pagination in other tables.
Links to any other associated PRs
[ x ] I have reviewed the contributing guide
[ x ] I have viewed, signed, and submitted the Contributor License Agreement
[ x ] I have made this pull request to the
mainbranch[ x ] I have run all the unit tests using
bundle exec rake[ ] I have run CF Acceptance Tests