Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Ruby 3 upgrade #2623

Closed
wants to merge 7 commits into from
Closed

[WIP] Ruby 3 upgrade #2623

wants to merge 7 commits into from

Commits on Jan 18, 2022

  1. Upgrade to Ruby 3 and update dependencies 

    Authored-by: Seth Boyles <sboyles@pivotal.io>
    @sethboyles
    sethboyles committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    fe092d5 View commit details
    Browse the repository at this point in the history

  2. Update keyword arguments for Ruby 3.0 

    Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
    @sethboyles @monamohebbi
    sethboyles and monamohebbi committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    b88b81e View commit details
    Browse the repository at this point in the history

  3. Create wrappers for regexes instead of singleton methods 

    * In Ruby 3.0, regexes are immutable and can't have singleton methods defined

Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
    @sethboyles @monamohebbi
    sethboyles and monamohebbi committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    e4a024f View commit details
    Browse the repository at this point in the history

  4. Some more keyword argument fixes 

    Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
    @sethboyles @monamohebbi
    sethboyles and monamohebbi committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    de3487a View commit details
    Browse the repository at this point in the history

  5. Fix equality assertion causing test error 

    eql is primarily used as a mathematical equals. Using it here was
causing a divison by 0 error due to some confusion.

Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Co-authored-by: Mona Mohebbi <mmohebbi@pivotal.io>
    @sethboyles @monamohebbi
    sethboyles and monamohebbi committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3e55c7d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Update fog-local to 0.8 

    Authored-by: Seth Boyles <sboyles@pivotal.io>
    @sethboyles
    sethboyles committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    85c0e25 View commit details
    Browse the repository at this point in the history

  2. Use new way of overriding helpers in Sinatra apps 

    Authored-by: Seth Boyles <sboyles@pivotal.io>
    @sethboyles
    sethboyles committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    6c63f99 View commit details
    Browse the repository at this point in the history