Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RubyZip to v1.2.2 #1225

Closed
wants to merge 1 commit into from
Closed

Bump RubyZip to v1.2.2 #1225

wants to merge 1 commit into from

Conversation

tcdowney
Copy link
Member

@tcdowney tcdowney commented Oct 1, 2018

RubyZip has now released a new version that includes the following
commit that the buildpacks team contributed:

rubyzip/rubyzip@c787d94

Will probably just merge this normally, but wanted to test some of our PR integrations.

  • Links to any other associated PRs

rubyzip/rubyzip#358

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

 RubyZip has now released a new version that includes the following
 commit that the buildpacks team contributed:

 rubyzip/rubyzip@c787d94

 [finished #160901074]
@cfdreddbot
Copy link

Hey tcdowney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/160901160

The labels on this github issue will be updated when the story is started.

@selzoc
Copy link
Member

selzoc commented Oct 1, 2018

No snyk check?

@tcdowney
Copy link
Member Author

tcdowney commented Oct 1, 2018

@selzoc what is this?
screen shot 2018-10-01 at 12 08 20 pm

@selzoc
Copy link
Member

selzoc commented Oct 1, 2018

The permissions must be such that only you can see them @tcdowney:
screen shot 2018-10-01 at 1 32 33 pm

@tcdowney
Copy link
Member Author

tcdowney commented Oct 4, 2018

This was done in d03baa6

@tcdowney tcdowney closed this Oct 4, 2018
@tcdowney tcdowney deleted the test-bump-rubyzip branch October 4, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants