Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack association to buildpack model [#153256959] #1064

Closed
wants to merge 1 commit into from

Commits on Apr 26, 2018

  1. Add stack association to buildpack model [#153256959]

    - Add "stack" to buildpack model
    - At migration time, buildpacks will be assigned default stack from
    stacks.yml file if its path is set in the STACKS_YML env var
    - hwc_buildpack is assigned the newer of windows2016,windows2012R2
    stacks if present in stacks.yml
    - if STACKS_YML is not set, buildpacks' stacks will be set to nil
    - Buildpacks are now unique over name AND stack
    - Sets buildpack stack from manifest.yml in buildpack zip on creation
    - Validate buildpack model stack against stack in buildpack zip manifest.yml
    - Validate stack exists upon buildpack bits upload
    - Include stack name in serialized buildpack filename
    - Only provide buildpacks for the relevant stack to the staging container
    - Handle buildpack stacks appropriately in the buildpack installer
    - Use fork of rubyzip/rubyzip to work around rubyzip/rubyzip#236
    
    NOTE: The API checkshum has changed due to adding stack as an input
    
    Signed-off-by: Dave Goddard <dave@goddard.id.au>
    Signed-off-by: Victoria Henry <vhenry@pivotal.io>
    Signed-off-by: Jackson Feeny <jacksonfeeny@gmail.com>
    Signed-off-by: Tyler Phelan <tphelan@pivotal.io>
    Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
    Signed-off-by: Leah Hanson <lhanson@pivotal.io>
    idoru committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    6aed8a2 View commit details
    Browse the repository at this point in the history