-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): Setup OpenTelemetry in all microservices #2866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
changed the title
feat(otel): Setup OpenTelemetry in all service, instrument gRPC client
feat(otel): Setup OpenTelemetry in all µservices, instrument gRPC client
Apr 19, 2024
silvestre
added
the
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
label
Apr 22, 2024
silvestre
force-pushed
the
setup-opentelemetry
branch
from
April 23, 2024 11:54
338cdcc
to
9c3a493
Compare
Quality Gate failedFailed conditions |
silvestre
force-pushed
the
setup-opentelemetry
branch
from
May 23, 2024 14:57
9c3a493
to
16c9eb5
Compare
silvestre
changed the title
feat(otel): Setup OpenTelemetry in all µservices, instrument gRPC client
feat(otel): Setup OpenTelemetry in all microservices
May 23, 2024
bonzofenix
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
geigerj0
reviewed
May 23, 2024
silvestre
force-pushed
the
setup-opentelemetry
branch
from
May 23, 2024 15:47
16c9eb5
to
887ccf2
Compare
# Issue OpenTelemetry was not set-up in all microservices, even though most micro-services access the DB and thus profit from having it enabled. # Fix `helpers.SetupOpenTelemetry` is now called in all main functions and the `otelmux.Middleware` is registered on all HTTPS servers.
silvestre
force-pushed
the
setup-opentelemetry
branch
from
May 24, 2024 09:28
887ccf2
to
bbee9ce
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OpenTelemetry was not set-up in all microservices, even though most
micro-services access the DB and thus profit from having it enabled.
Fix
helpers.SetupOpenTelemetry
is now called in all main functions and theotelmux.Middleware
is registered on all HTTPS servers.