Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): Setup OpenTelemetry in all microservices #2866

Merged
merged 1 commit into from
May 24, 2024

Conversation

silvestre
Copy link
Member

@silvestre silvestre commented Apr 19, 2024

Issue

OpenTelemetry was not set-up in all microservices, even though most
micro-services access the DB and thus profit from having it enabled.

Fix

helpers.SetupOpenTelemetry is now called in all main functions and the
otelmux.Middleware is registered on all HTTPS servers.

@silvestre silvestre changed the title feat(otel): Setup OpenTelemetry in all service, instrument gRPC client feat(otel): Setup OpenTelemetry in all µservices, instrument gRPC client Apr 19, 2024
@silvestre silvestre added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Apr 22, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@silvestre silvestre changed the title feat(otel): Setup OpenTelemetry in all µservices, instrument gRPC client feat(otel): Setup OpenTelemetry in all microservices May 23, 2024
@silvestre silvestre marked this pull request as ready for review May 23, 2024 14:59
Copy link
Contributor

@bonzofenix bonzofenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Issue

OpenTelemetry was not set-up in all microservices, even though most
micro-services access the DB and thus profit from having it enabled.

# Fix

`helpers.SetupOpenTelemetry` is now called in all main functions and the
`otelmux.Middleware` is registered on all HTTPS servers.
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@silvestre silvestre merged commit d5d2484 into main May 24, 2024
29 of 30 checks passed
@silvestre silvestre deleted the setup-opentelemetry branch May 24, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants