Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): Enable FIPS-only mode #2723

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(crypto): Enable FIPS-only mode #2723

wants to merge 2 commits into from

Conversation

silvestre
Copy link
Member

  • feat(crypto): Enable GOEXPERIMENT boringcrypto
  • feat(crypto): Enable FIPS-only mode

@silvestre silvestre changed the title boringcrypto feat(crypto): Enable FIPS-only mode Mar 7, 2024
@silvestre silvestre added Do Not Merge allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Mar 7, 2024
@@ -28,6 +28,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -25,6 +25,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -25,6 +25,8 @@ import (
"github.com/tedsuo/ifrit/sigmon"

"code.cloudfoundry.org/app-autoscaler/src/autoscaler/metricsforwarder/manager"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -25,6 +25,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -21,6 +21,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -21,6 +21,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

@@ -24,6 +24,8 @@ import (
"github.com/tedsuo/ifrit"
"github.com/tedsuo/ifrit/grouper"
"github.com/tedsuo/ifrit/sigmon"

_ "crypto/tls/fipsonly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
could not import crypto/tls/fipsonly (-: build constraints exclude all Go files in /__t/go/1.21.3/x64/src/crypto/tls/fipsonly) (typecheck)

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
50.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. Do Not Merge enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant