-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate "deployment" in metadata binding #5818
Conversation
🦋 Changeset detectedLatest commit: aaab82e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-wrangler-5818 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5818/npm-package-wrangler-5818 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-wrangler-5818 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-create-cloudflare-5818 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-kv-asset-handler-5818 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-miniflare-5818 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-pages-shared-5818 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-vitest-pool-workers-5818 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
5edc3de
to
70ab7a0
Compare
29ba36a
to
3f724ff
Compare
f0775ab
to
fe72cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the docs on https://developers.cloudflare.com/workers/wrangler/configuration as well? There's no mention there of either the old metadata
or the new version_metadata
bindings. I am aware that https://developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata exists, just calling it out
fe72cbf
to
aaab82e
Compare
Yep good callout, will add there :) |
What this PR solves / how to test
WC-1755
Author has addressed the following