Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm etc #5809

Merged
merged 3 commits into from
May 15, 2024
Merged

Update pnpm etc #5809

merged 3 commits into from
May 15, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented May 13, 2024

What this PR solves / how to test

Updates the monorepo to use pnpm 9.1.1 both locally and in GH actions.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: GH Action configuration change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: GH Action configuration change
  • Public documentation

@petebacondarwin petebacondarwin requested review from a team as code owners May 13, 2024 09:34
Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 5b190f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label May 13, 2024
@petebacondarwin petebacondarwin marked this pull request as draft May 13, 2024 09:39
@petebacondarwin petebacondarwin force-pushed the update-pnpm-etc branch 2 times, most recently from f3e7ea5 to c93b3df Compare May 13, 2024 09:54
@petebacondarwin
Copy link
Contributor Author

ERROR: This version of pnpm requires at least Node.js v18.12
The current version of Node.js is v16.18.1

😢

So fixing our node.js dependency must come first...

Copy link
Contributor

github-actions bot commented May 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-wrangler-5809

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5809/npm-package-wrangler-5809

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-wrangler-5809 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-create-cloudflare-5809 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-cloudflare-kv-asset-handler-5809
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-miniflare-5809
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-cloudflare-pages-shared-5809
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9098443256/npm-package-cloudflare-vitest-pool-workers-5809

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.56.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the update-pnpm-etc branch 3 times, most recently from c45a069 to 806ab7f Compare May 15, 2024 13:10
@petebacondarwin petebacondarwin marked this pull request as ready for review May 15, 2024 14:09
@petebacondarwin
Copy link
Contributor Author

Node.js 18 is in, so this PR is now ready to go!

@penalosa penalosa merged commit 9c469f6 into main May 15, 2024
26 of 29 checks passed
@penalosa penalosa deleted the update-pnpm-etc branch May 15, 2024 16:57
fhanau added a commit to cloudflare/workerd that referenced this pull request May 26, 2024
fhanau added a commit to cloudflare/workerd that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants