fix: Allow CJS to import index.js files using directory path #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`maybeGetTargetFilePath` did not correctly deal with implicit import of index.js files. If target is a directory, we need to check if it has an index (js, mjs, cjs) file and return that file path if present.
🦋 Changeset detectedLatest commit: e34b183 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Reviewers: I do not see any related tests in this package. Any ideas how to test this? |
arv
added a commit
to arv/pg-logical-replication
that referenced
this pull request
May 3, 2024
This is mostly to unblock `@cloudflare/vitest-worker-pool` which has a bug that prevents it from resolving `dir/a/b` to `dir/a/b/index.js`. cloudflare/workers-sdk#5749 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybeGetTargetFilePathdid not correctly deal with implicit import of index.js files.If target is a directory, we need to check if it has an index (js, mjs, cjs) file and return that file path if present.
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following