-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate duplicate bindings across all binding types #5737
base: main
Are you sure you want to change the base?
Validate duplicate bindings across all binding types #5737
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-wrangler-5737 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5737/npm-package-wrangler-5737 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-wrangler-5737 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-create-cloudflare-5737 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-kv-asset-handler-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-miniflare-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-pages-shared-5737 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-vitest-pool-workers-5737 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
11deac5
to
cd5eb7a
Compare
]) | ||
); | ||
|
||
console.log(bindingsGroupedByType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this log needed here?
this LGTM. Left a small comment + don't forget about adding a changeset. Otherwise, good to go |
What this PR solves / how to test
Fixes #2893
Author has addressed the following