Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle ?raw suffix #5732

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hrueger
Copy link

@hrueger hrueger commented May 1, 2024

What this PR solves / how to test

Fixes #5731

Author has addressed the following

@hrueger hrueger requested a review from a team as a code owner May 1, 2024 11:05
Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 0b41656

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a PR!

If we were to add support for ?raw, I think that would take the form of a adhoc rule so that we can ensure we handle binary files, for example. Additionally, it looks like a lot of the JS ecosystem is starting to converge on import attributes which, potentially, might be preferred over query params on the import identifier. If it's alright, I'd hold off and wait for some official product direction here before continuing with this PR. Thanks again for the PR and highlighting the need for something in this space though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: handle ?raw suffix
2 participants