Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] Framework migration diffs #5716

Merged
merged 18 commits into from
May 20, 2024
Merged

[C3] Framework migration diffs #5716

merged 18 commits into from
May 20, 2024

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Apr 26, 2024

What this PR solves / how to test

When running c3 e2e tests on the release branch, this change will store the diff between what is created by framework scaffolding tools and the parts which C3 layers on top. This is only done for full-stack framework templates In doing so, this will create a rough guide for users on how to migrate existing apps.

The result will be saved as an artifact, and once a release is successfully published, a PR will be created to the cloudflare-docs repo with the result.

Author has addressed the following

@jculvey jculvey requested review from a team as code owners April 26, 2024 12:46
Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 4fabcce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 26, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-wrangler-5716

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5716/npm-package-wrangler-5716

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-wrangler-5716 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-create-cloudflare-5716 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-kv-asset-handler-5716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-miniflare-5716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-pages-shared-5716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-vitest-pool-workers-5716

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.57.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jculvey jculvey changed the title WIP: [C3] Framework migration diffs [C3] Framework migration diffs May 3, 2024
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 😃

I've added a few comments though, please have a look 🙏

.github/actions/create-c3-docs-pr/action.yml Outdated Show resolved Hide resolved
.github/actions/create-c3-docs-pr/action.yml Show resolved Hide resolved
packages/c3-framework-diffs/.gitkeep Outdated Show resolved Hide resolved
packages/create-cloudflare/src/git.ts Outdated Show resolved Hide resolved
packages/create-cloudflare/src/frameworks/index.ts Outdated Show resolved Hide resolved
packages/create-cloudflare/e2e-tests/frameworks.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! thanks a lot for addressing my comments 🚀 😄

@jculvey jculvey merged commit d075478 into main May 20, 2024
27 checks passed
@jculvey jculvey deleted the c3-migration-diffs branch May 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants