-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Early Hints for modulepreload
#5674
Conversation
🦋 Changeset detectedLatest commit: 6b823f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-wrangler-5674 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5674/npm-package-wrangler-5674 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-wrangler-5674 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-create-cloudflare-5674 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-cloudflare-kv-asset-handler-5674 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-miniflare-5674 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-cloudflare-pages-shared-5674 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9172210492/npm-package-cloudflare-vitest-pool-workers-5674 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there are tests for this...
`"</a.png>; rel="preload"; as=image, </b.png>; rel="preload"; as=image"` |
@petebacondarwin I have merged the changes on main as there was a conflict, tell me if I red it wrong, but there is now a cache control header on the early hints cache, which makes sense, so merged it in here. |
Does it make sense to test for the specific module preload part? The preconnect one isn't checked either... |
I realised that we were not checking the linting on pages-shared, so I have just pushed an extra commit that cleans that up. |
Might make sense to just add the |
If you have time, please do. Thanks. |
Added a small fixup commit because some snapshot tests needed updating. But otherwise looks good. We just need a review from a pages team member and then we are good to merge. |
I'll get this released along with #5875 hopefully tomorrow or Thursday @itsmatteomanf |
What this PR solves / how to test
This PR adds support for
<link rel="modulepreload" href="...">
entries in the HTML, to allow them to be added to the Link header.Author has addressed the following