Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Hack Week prototype.
Allows you to define, in modules, other modules which should be picked up by Wrangler when it constructs its bundle. This is useful for lazy-loading boundaries and assets! I have needed this multiple times in the past, particularly when writing libraries (you don't want your users to have to copy-paste files around or put stuff in
[[rules]]
just for you).Happy to bike-shed on the exact way to define these things.
An open question: should it be limited to only child dirs? Or have some sort of user acknowledgement? I could see a concern around a lib sneakily including
/etc/passwd
in a bundle or something. That's already doable today for any file which matches a rule but this just makes it that much easier to grab files.Author has addressed the following