chore: upgrade to miniflare@2.12.1 & @miniflare/tre@3.0.0-next.10
#2771
Conversation
🦋 Changeset detectedLatest commit: 9ac7753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4227368447/npm-package-wrangler-2771You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2771/npm-package-wrangler-2771Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4227368447/npm-package-wrangler-2771 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4227368447/npm-package-cloudflare-pages-shared-2771Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
+ Coverage 73.98% 74.00% +0.01%
==========================================
Files 166 166
Lines 10161 10163 +2
Branches 2705 2705
==========================================
+ Hits 7518 7521 +3
+ Misses 2643 2642 -1
|
| @@ -88,4 +88,9 @@ declare global { | |||
| // by `vite`. Therefore, define it as an empty interface. | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | |||
| interface Worker {} | |||
|
|
|||
| // `MessagePort` has been global since Node 15, but isn't included in | |||
| // `@types/node`. This is required by `undici`'s types. | |||
There was a problem hiding this comment.
Is there an issue open for this on @types/node? If not, maybe we should open one?
There was a problem hiding this comment.
Is looks like this was added in DefinitelyTyped/DefinitelyTyped#59905, which isn't included in our @types/node version (16.11.22). I tried upgrading to 16.18.12 (we don't want to upgrade beyond 16 because our minimum supported Node version is 16.13.0), and I still get the same missing MessagePort error. I think we should leave this for now. 👍
What this PR solves / how to test:
Upgrades
miniflare(for--local) to2.12.1and@miniflare/tre(for--experimental-local) to3.0.0-next.10.Associated docs issues/PR:
N/A
Author has included the following, where applicable:
Tests(passes existing)Reviewer has performed the following, where applicable: