Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent fixture tests #1877

Closed
wants to merge 10 commits into from
Closed

Concurrent fixture tests #1877

wants to merge 10 commits into from

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Sep 17, 2022

This makes all the fixture tests less flaky, since they no longer compete for fixed ports. They all now start up on port 0 and await a message from wrangler telling them which port they were assigned. This means that the fixtures can be run concurrently.

  • Announce with IPC running server
  • Re-write tests to be concurrent and consume IPC message
  • local-mode-tests
  • Actually run the fixtures concurrently
  • external-durable-objects-app
  • service-bindings-app
  • Fix --port=0 logging miniflare#382

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2022

⚠️ No Changeset found

Latest commit: edac49a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3083612480/npm-package-wrangler-1877

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1877/npm-package-wrangler-1877

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3083612480/npm-package-wrangler-1877 dev path/to/script.js

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #1877 (757f493) into main (adfc52d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 757f493 differs from pull request most recent head edac49a. Consider uploading reports for the commit edac49a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   77.49%   77.48%   -0.01%     
==========================================
  Files         105      105              
  Lines        7473     7472       -1     
  Branches     1972     1971       -1     
==========================================
- Hits         5791     5790       -1     
  Misses       1682     1682              
Impacted Files Coverage Δ
packages/wrangler/src/dev/local.tsx 30.67% <0.00%> (ø)
packages/wrangler/src/dev.tsx 85.30% <100.00%> (-0.07%) ⬇️
packages/wrangler/src/dev/start-server.ts 76.00% <100.00%> (ø)

@GregBrimble GregBrimble force-pushed the concurrent-fixture-tests branch 2 times, most recently from 5505cda to b12fbff Compare September 17, 2022 22:55
@GregBrimble GregBrimble force-pushed the concurrent-fixture-tests branch 3 times, most recently from 0a5b573 to 02ed83f Compare September 17, 2022 23:52
@rozenmd
Copy link
Contributor

rozenmd commented Sep 18, 2022

I love this!

@GregBrimble GregBrimble deleted the concurrent-fixture-tests branch November 23, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants