Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV Testing #528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add KV Testing #528

wants to merge 2 commits into from

Conversation

Kakapio
Copy link
Contributor

@Kakapio Kakapio commented Apr 3, 2024

I had a lot of difficulty getting the tests working in this repo. I had issues with not including the tests in workers-kv as a member of the main Cargo.toml. There were also issues with the versioning of the various nested Cargo.toml files. I think it would probably be prudent to separate the workers-kv/tests into its own member. I have not yet seen rust-based tests anywhere else in this repo so I wanted to get feedback on that.

I will make a follow-up pull request for updated dependencies and separation of testing modules. I will also look into updating the tests to use Miniflare 3 instead of Miniflare 1.

@Kakapio Kakapio marked this pull request as ready for review April 3, 2024 10:34
@kflansburg
Copy link
Member

There are only a handful of endpoints here, and this very closely matches the pattern used in the main test suite, would it be simpler to just move these test cases over to worker-sandbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants