adds curl/static-curl feature to wasm-pack install #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes cloudflare#304 wasm-pack will exit with core dumped on some machines because of libc or curl compatibility issues. This feature solves it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #304
Worker-rs installs a version of wasm-pack that can be incompatible with some systems due to curl or libc incompatibilities. Installing it with this feature enabled solves this issue.
This can be done manually:
cargo install wasm-pack --features curl/static-curlI am not sure this should be merged.
This feature makes so curl gets statically linked in the wasm-pack binary. It is unlikely that it would cause issues on other machines.
Also, it will not overwrite wasm-pack if it is installed already.