fix(worker-build): prevent script will never generate a response #256
+66
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdenty
commented
Dec 31, 2022
| export * from "./index_bg.js"; | ||
| export default { | ||
| fetch: async (...args) => { | ||
| INSERT_INIT(); |
There was a problem hiding this comment.
this is replaced in the script below
samdenty
commented
Dec 31, 2022
| @@ -130,14 +131,50 @@ fn bundle(esbuild_path: &Path) -> Result<()> { | |||
| "--outfile=shim.mjs", | |||
| ]); | |||
|
|
|||
| if !no_minify { | |||
There was a problem hiding this comment.
we can't run minify, as we need the non-minified source to run transforms
samdenty
commented
Dec 31, 2022
| fs::write(path.join("./shim.mjs"), result)?; | ||
|
|
||
| // re-bundle the shim with minification flag | ||
| if !no_minify { |
There was a problem hiding this comment.
we re-run esbuild to minify it
1 task
|
ping @zebp i wonder if you know who to hit up to get this in, this is blocking me from using worker-rs |
left a reply in the issue |
|
Is there any update on this? |
xtuc
reviewed
May 2, 2023
|
|
||
| return imports.fetch(...args); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
this is missing the scheduled entrypoint
xtuc
reviewed
May 2, 2023
| @@ -1,7 +1,12 @@ | |||
| import * as imports from "./index_bg.js"; | |||
| export * from "./index_bg.js"; | |||
There was a problem hiding this comment.
This prevents Durable Objects from being exported no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #255
There's no clean way to convert the
index_bg.jswhich contains ESM exports, into a function which is called on eachfetch().So in this PR, I basically split the two parts of the bundle up and move the initialization inside the fetch function, by replacing the
INSERT_INIT()tokenThis is kinda hacky, but it works. It fixes the script will never generate a response errors that can occur when sharing the wasm state across requests.