Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner to README #9

Merged
merged 3 commits into from Sep 21, 2022
Merged

Add banner to README #9

merged 3 commits into from Sep 21, 2022

Conversation

neynah
Copy link
Contributor

@neynah neynah commented Sep 20, 2022

Add @londonzhang's amazing banner illustration to the README. Let us know if the banner.png should be moved into another path. CC @Electroid

@jasnell
Copy link
Member

jasnell commented Sep 20, 2022

One of the other open PRs adds a docs directory. It hasn't landed yet but that's ok. Let's move the banner into a docs/assets directory here. Otherwise, LGTM

@kentonv
Copy link
Member

kentonv commented Sep 21, 2022

Oops, looks like your second commit deleted the file instead of moving it.

@neynah
Copy link
Contributor Author

neynah commented Sep 21, 2022

Oops, looks like your second commit deleted the file instead of moving it.

Oops! Added it back in, thanks!

@jasnell jasnell merged commit 41c80d4 into main Sep 21, 2022
@jasnell jasnell deleted the readme-banner branch September 21, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants