Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Do not log tunneled exceptions that cause alarm retries #80

Merged
merged 1 commit into from Oct 6, 2022

Conversation

bcaimano
Copy link
Contributor

@bcaimano bcaimano commented Oct 6, 2022

Failures that lead to alarm retries may in fact be JSG errors.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bcaimano
Copy link
Contributor Author

bcaimano commented Oct 6, 2022

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 6, 2022
@kentonv
Copy link
Member

kentonv commented Oct 6, 2022

Oh weird I could have sworn we made this change already.

@kentonv kentonv merged commit 6cbe16d into cloudflare:main Oct 6, 2022
@bcaimano bcaimano deleted the bcaimano/alarm-retry-log branch October 10, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants