New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WebSocket Compression in `workerd` #69

Merged

kentonv merged 4 commits into cloudflare:main from MellowYarker:milan/enable-websocket-compression

Oct 5, 2022

Contributor

MellowYarker commented Oct 3, 2022

No description provided.


          Pass request headers to Response::send()

When terminating a websocket in a worker (as a server), we need to
access the client request's headers to determine what (if any)
compression parameters should be used.

github-actions bot commented Oct 3, 2022 •

edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Contributor Author

MellowYarker commented Oct 3, 2022

I have read the CLA Document and I hereby sign the CLA

Contributor Author

MellowYarker commented Oct 3, 2022

recheck

github-actions bot added a commit that referenced this pull request


          @MellowYarker has signed the CLA from Pull Request #69

60643e1

kentonv reviewed

View reviewed changes

src/workerd/server/server.c++ Show resolved Hide resolved

kentonv reviewed

View reviewed changes

src/workerd/api/http.c++ Outdated Show resolved Hide resolved

kentonv reviewed

View reviewed changes

src/workerd/io/compatibility-date.capnp Outdated Show resolved Hide resolved

kentonv reviewed

View reviewed changes

src/workerd/api/http.c++ Outdated Show resolved Hide resolved

kentonv reviewed

View reviewed changes

src/workerd/api/http.h Outdated Show resolved Hide resolved


          Enable compression in HttpServer

0df9fc6

By default, kj sets the compression mode to `NO_COMPRESSION`. We want to
use `MANUAL_COMPRESSION` in Workerd so we modify the setting here.

MellowYarker force-pushed the milan/enable-websocket-compression branch 2 times, most recently from ce030b8 to b49ad1e Compare

October 4, 2022 15:45

kentonv reviewed

View reviewed changes

src/workerd/api/http.c++ Outdated Show resolved Hide resolved

src/workerd/api/web-socket.c++ Outdated Show resolved Hide resolved

MellowYarker added 2 commits

October 4, 2022 12:42


          Add webSocketCompression compat flag

e8d8715

If this flag is not set, we will strip `Sec-WebSocket-Extensions`
from subrequests (including `new WebSocket()`) and responses.


          Update Cap'n Proto dependency

5370f10

MellowYarker force-pushed the milan/enable-websocket-compression branch from 2873e9f to 5370f10 Compare

October 4, 2022 16:42

kentonv approved these changes

View reviewed changes

kentonv merged commit 41d09c1 into cloudflare:main

Contributor Author

MellowYarker commented Oct 5, 2022

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment