Warn if URLSearchParams has() or delete() are called with multiple args #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for landing support for the new value arguments added recently to URLSearchParams.has() and delete(), we need to know if adding the new arguments will break any existing workers. This commit adds a warning. Refs: whatwg/url#735
jasnell
force-pushed
the
jsnell/prep-for-urlsearchparams-new-args
branch
from
a97a740
to
9e3ff32
Compare
ohodson
reviewed
May 12, 2023
ohodson
approved these changes
May 12, 2023
kentonv
approved these changes
May 12, 2023
Co-authored-by: Orion Hodson <orion@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for landing support for the new value arguments added recently to URLSearchParams.has() and delete(), we need to know if adding the new arguments will break any existing workers. This commit adds a warning.
Refs: whatwg/url#735