Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README with instructions to clean build cache. #59

Merged
merged 2 commits into from Oct 3, 2022

Conversation

jonasclaes
Copy link
Contributor

Due to a rare issue explained in #41, I've added instructions to clean the cache and try rebuilding.

@kentonv
Copy link
Member

kentonv commented Sep 30, 2022

Hmm, I wonder if we should create a "build troubleshooting" document for tips like this? I suspect there will be move of these and it might clutter up the readme.

I think we've seen a few different types of errors caused by this, not just include-related, so I might describe it more like:

If you run a Bazel build before you've installed some dependencies (like clang or libc++), and then you install the dependencies, you must clean Bazel's cache, otherwise you might get strange errors.

@jonasclaes
Copy link
Contributor Author

Hmm, I wonder if we should create a "build troubleshooting" document for tips like this? I suspect there will be move of these and it might clutter up the readme.

Whilst I'm not against the idea of a document containg troubleshooting "guides", at this moment I do not think it is necessary and we should cross this bridge when we get there?

I think we've seen a few different types of errors caused by this, not just include-related, so I might describe it more like:

If you run a Bazel build before you've installed some dependencies (like clang or libc++), and then you install the dependencies, you must clean Bazel's cache, otherwise you might get strange errors.

That's a great idea! I've never written the greatest documentation so I'm still learning as we go and this is a nice addition. Shall I update the PR?

README.md Outdated Show resolved Hide resolved
Updated description of build steps on error

Co-authored-by: James M Snell <jasnell@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jonasclaes
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 3, 2022
@kentonv kentonv merged commit 6c613df into cloudflare:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants