Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CLA Assistant on this repo #55

Merged
merged 1 commit into from Sep 30, 2022
Merged

Enable CLA Assistant on this repo #55

merged 1 commit into from Sep 30, 2022

Conversation

larcher
Copy link
Contributor

@larcher larcher commented Sep 29, 2022

With the CLA Assistant able, when a PR is opened it will check if the person has signed the CLA before, and if not, add a comment like this:
image

The link there goes to https://www.cloudflare.com/cla/

  • Signatures will be stored in a file in this repo: signatures/version1/cla.json (this is configurable, and could even be in a separate repo)
  • For users or bots who should not be required to sign the CLA, there's an allowlist: option in this file.
  • There's currently no way to make an exception for "trivial changes" (fixing typos, etc)

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we absolutely have to, then ...grrr... ok.
Would absolutely prefer not to have a CLA tho.

@kentonv kentonv merged commit bcf3e4b into cloudflare:main Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants