Fix clang 11 and make icudata embed portable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more broadly available, e.g. it's the default on Debian Bullseye. This also means we don't need to hard-code the full path to Clang anymore, which is pretty nice.
jasnell
reviewed
Sep 19, 2022
| * Clang 15 | ||
| * libc++ 15 | ||
| * Clang 11+ (e.g. package `clang` on Debian Bullseye) | ||
| * libc++ 11+ (e.g. packages `libc++-dev` and `libc++abi-dev` on Debian Bullseye) |
There was a problem hiding this comment.
Should we explicitly recommend at least clang 15 still?
There was a problem hiding this comment.
Nah, I don't think it matters. The only difference I'm aware of is the one missing use of concepts but it doesn't seem like enough to tell people to do extra work.
jasnell
approved these changes
Sep 19, 2022
wd_cc_embed doesn't seem to work on Mac and it was magic copy-pasta to start with so I'm not sure how to fix it. This approach is portable, but does result in a 57MB generated C++ file which is kinda gross.
kentonv
force-pushed
the
kenton/clang-11
branch
from
48c862d
to
bbff5bf
Compare
mrbbot
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.