Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workerd::api::gpu::AsyncRunner
was using a different instance ofTimeoutId::Generator
than is used forsetTimeout
calls from JS.I fix this by moving ownership of the
TimeoutIdGenerator
into theTimeoutManagerImpl
itself.In the case of
gpu::AsyncRunner
, it doesn't look like there's any need to generate an ID for the timeout, so we could alternatively approach this by re-using the timeout logic but not generating an ID in order to avoid silently using up timeout ID values under the hood. Not sure whether it's worth it.