Fix top level randomness in aiohttp #2108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/aiohttp-top-level-random
branch
from
6418dc6
to
2a52995
Compare
hoodmane
force-pushed
the
hoodmane/aiohttp-top-level-random
branch
from
2a52995
to
49712d5
Compare
|
It works: |
hoodmane
force-pushed
the
hoodmane/aiohttp-top-level-random
branch
from
49712d5
to
87088de
Compare
garrettgu10
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiohttp instantiates a
random.Random()in order to be a default argument forWebSocketWriter. Instead, use therandommodule itself for this which implements the same interface asRandom.Should fix one of the test failures in #2096.