WorkerdAPI: Factor out Python module setup from compileModules #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added ~100 lines of Python-only logic to compileModules which is otherwise only ~30 lines long. I moved it into a separate function.
garrettgu10
approved these changes
Apr 25, 2024
dom96
approved these changes
Apr 30, 2024
Comment on lines
+395
to
+396
| void | ||
| setupPythonModules( |
There was a problem hiding this comment.
Suggested change
| void | |
| setupPythonModules( | |
| void setupPythonModules( |
| config::Worker::Reader conf, | ||
| const PythonConfig& pythonConfig, | ||
| CompatibilityFlags::Reader featureFlags | ||
| ) { |
There was a problem hiding this comment.
Nit: This also doesn't match kj code style
| ) { | ||
| using namespace workerd::api::pyodide; | ||
| auto confModules = conf.getModules(); | ||
| auto modules = jsg::ModuleRegistryImpl<JsgWorkerdIsolate_TypeWrapper>::from(lockParam); |
There was a problem hiding this comment.
Suggested change
| auto modules = jsg::ModuleRegistryImpl<JsgWorkerdIsolate_TypeWrapper>::from(lockParam); | |
| auto modules = jsg::ModuleRegistryImpl<JsgWorkerdIsolate_TypeWrapper>::from(lockParam); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added ~100 lines of Python-only logic to compileModules which is otherwise only ~30 lines long. I moved it into a separate function.